Page MenuHomePhabricator

Build: Add json dependency to vg_common
AbandonedPublic

Authored by jsuya on Jun 2 2020, 10:35 PM.

Details

Summary

need rlottie package for json.

Test Plan

Enable json vg loader & build
(remove 'json' in evas-loaders-disabler)

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16900
Build 11234: arc lint + arc unit
jsuya created this revision.Jun 2 2020, 10:35 PM
jsuya requested review of this revision.Jun 2 2020, 10:35 PM
Hermet accepted this revision.Jun 2 2020, 10:53 PM

@bu5hm4n could you please verify this?

This revision is now accepted and ready to land.Jun 2 2020, 10:53 PM

While i agree on the meson-level, i am kind of wondering why this is needed, rlottie is already added as a dep by the vg loader, why is this additionally needed ?

jsuya added a comment.EditedJun 3 2020, 4:23 AM

When building with json vg loader enabled, a build error occurred.

/usr/bin/ld: src/tests/evas/6440e44@@evas_suite@exe/.._.._static_libs_vg_common_vg_common_json.c.o: undefined reference to symbol 'lottie_animation_property_override'
/usr/local/lib/x86_64-linux-gnu/librlottie.so.0: error adding symbols: DSO missing from command line

I do not know much detail about meson script. But from what I found...
rlottie dependancy is added to evas_static_list. But evas_suite refers to evas_ext_none_static_deps. I think that's why evas_suite can't find rlottie package.
I think I might be wrong. Please let me know if there is a good way.

ooooooooh, do we use vgcommon directly in tests ?

https://phab.enlightenment.org/D11923 Can you check if this fixes the issue for you?

jsuya abandoned this revision.Jun 3 2020, 5:13 AM

Yes Thanks :)