Page MenuHomePhabricator

eina_test_file.c: Do not test errno if the function doesn't fail
ClosedPublic

Authored by walac on Jun 12 2020, 11:50 AM.

Details

Summary

errno only holds a valid value if the function returns an error.

ref: windows-native-port

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
walac created this revision.Jun 12 2020, 11:50 AM
walac requested review of this revision.Jun 12 2020, 11:50 AM
vtorri added inline comments.Jun 12 2020, 1:13 PM
src/tests/eina/eina_test_file.c
783–784

so is this definition oferrno useful ?

walac updated this revision to Diff 30630.Jun 12 2020, 1:27 PM

Remove all references to errno in eina_test_file.c

walac marked an inline comment as done.Jun 12 2020, 1:29 PM
walac added inline comments.
src/tests/eina/eina_test_file.c
783–784

Good catch, I updated the patch

stefan_schmidt accepted this revision.Jun 23 2020, 5:02 AM
This revision is now accepted and ready to land.Jun 23 2020, 5:02 AM
This revision was automatically updated to reflect the committed changes.