Page MenuHomePhabricator

Efl.Canvas.Vg.Object: Fix wrong render area
ClosedPublic

Authored by jsuya on Jun 15 2020, 3:08 AM.

Details

Summary

When determining the size of the ector buffer,
it was used the smaller of the object's geometry or path_bounds.
However, because of that, path worked as absolute coordinates.
path_bounds should be relative to geometry of object.

Test Plan


original

before
+ evas_object_geometry_set(vg, 100, 100, 200, 200);

after
+ evas_object_geometry_set(vg, 100, 100, 200, 200);

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16993
Build 11301: arc lint + arc unit
jsuya created this revision.Jun 15 2020, 3:08 AM
jsuya requested review of this revision.Jun 15 2020, 3:08 AM
jsuya edited the test plan for this revision. (Show Details)Jun 15 2020, 3:09 AM
jsuya edited the test plan for this revision. (Show Details)Jun 15 2020, 3:45 AM

+1 looks good to me!

Hermet requested changes to this revision.Jun 15 2020, 5:55 PM

what happens if r is not initialized at this condition? if (pd->viewbox.w != 0 && pd->viewbox.h !=0)

This revision now requires changes to proceed.Jun 15 2020, 5:55 PM
jsuya updated this revision to Diff 30646.Jun 15 2020, 6:30 PM

Add initialization code.

Hermet requested changes to this revision.Jun 15 2020, 6:48 PM
Hermet added inline comments.
src/lib/evas/canvas/efl_canvas_vg_object.c
743–744

Now, It looks Eina_Rect r is useless.... you can update render_rect directly.

This revision now requires changes to proceed.Jun 15 2020, 6:48 PM
jsuya updated this revision to Diff 30648.Jun 15 2020, 7:18 PM

Update code

jsuya marked an inline comment as done.Jun 15 2020, 7:20 PM
jsuya added inline comments.
src/lib/evas/canvas/efl_canvas_vg_object.c
743–744

You are right. r is not necessary. I refactored the code. thanks

Hermet accepted this revision.Jun 15 2020, 9:09 PM
This revision is now accepted and ready to land.Jun 15 2020, 9:09 PM
Hermet closed this revision.Jun 15 2020, 9:10 PM