Page MenuHomePhabricator

Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds.
AbandonedPublic

Authored by jsuya on Jun 15 2020, 3:18 AM.

Details

Summary

When calculating path_bounds, it referenced the stroke width or miterlimit value.
The size of vg object is passed from path_bounds.
Therefore, the stroke information is included in the size.
This patch prevents it and uses a separate local function in Efl.Canvas.Vg.Object.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16992
Build 11300: arc lint + arc unit
jsuya created this revision.Jun 15 2020, 3:18 AM
jsuya requested review of this revision.Jun 15 2020, 3:19 AM
kimcinoo requested changes to this revision.Jun 15 2020, 4:54 PM
kimcinoo added inline comments.
src/lib/evas/canvas/efl_canvas_vg_object.c
722

Please let me know reason of -1, -1 I just wonder.
And you could initialize s at line 719 as you doe for children at line 717

751

you may need to remove this line with 772 line

This revision now requires changes to proceed.Jun 15 2020, 4:54 PM
jsuya updated this revision to Diff 30647.Jun 15 2020, 6:42 PM

Update code

jsuya marked 2 inline comments as done.Jun 15 2020, 6:45 PM
jsuya added inline comments.
src/lib/evas/canvas/efl_canvas_vg_object.c
722

There is no special reason. However, I think it will be helpful to some things because the cause differs depending on whether pos of s is 0, 0 or -1, -1 after bouns_get.

Hermet requested changes to this revision.Jun 15 2020, 9:14 PM

this looks wrong to me.
if user need the actual bound of the shape trees from the container, how they make it?

This revision now requires changes to proceed.Jun 15 2020, 9:14 PM
jsuya abandoned this revision.Jun 15 2020, 11:23 PM
jsuya marked an inline comment as done.

Abandon this patch.
The way to include stroke width in container's path bounds is wrong.
We need an API of separate VG classes that can provide this feature(actual size with stroke width area), not a local function of VG Object.