Page MenuHomePhabricator

elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice
AbandonedPublic

Authored by herb on Jun 17 2020, 3:19 AM.

Details

Summary

when trying to set file using url path twice, the second api call's return value is EINA_FALSE
since image obj has already has same file path. After applying Efl.File interface, the behavior is changed compared to before.
both of the return values should be EINA_TRUE.
@fix

ex)
Eina_Bool ret1, ret2;
ret1 = elm_image_file_set(image, "http://sameurl/image.jpg", NULL);
ret2 = elm_image_file_set(image, "http://sameurl/image.jpg", NULL);
ret1 and ret2 should be EINA_TURE

Test Plan

call elm_image_file_set api with same url path
see the return value

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17016
Build 11321: arc lint + arc unit
herb created this revision.Jun 17 2020, 3:19 AM
herb requested review of this revision.Jun 17 2020, 3:19 AM
Hermet requested changes to this revision.Jun 17 2020, 4:14 AM

how this patch helps to this scenario:

ex)
Eina_Bool ret1, ret2;
ret1 = elm_image_file_set(image, "http://sameurl/image.jpg", NULL);
ret2 = elm_image_file_set(image, "http://sameurl/image.jpg", NULL);
ret1 and ret2 should be EINA_TURE

src/lib/elementary/efl_ui_image.c
2424

looks like it always return false if the image file is remote type?

This revision now requires changes to proceed.Jun 17 2020, 4:14 AM
herb abandoned this revision.Jun 17 2020, 4:28 AM

This patch will be replaced with D11979