Page MenuHomePhabricator

efl-one: Get c_args from library to include in compilation
Needs RevisionPublic

Authored by felipealmeida on Jun 18 2020, 7:24 PM.

Details

Reviewers
bu5hm4n
Summary

This is necessary so we can have the correct api symbol definition for
exporting or importing for each library.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 17031
felipealmeida created this revision.Jun 18 2020, 7:24 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

felipealmeida requested review of this revision.Jun 18 2020, 7:24 PM
bu5hm4n requested changes to this revision.Jul 6 2020, 8:06 AM
bu5hm4n added a subscriber: bu5hm4n.

Mhm, can you elaborate why this is needed ?
As of right now, the package_c_args from the lib will be in package_c_args in meson.build:449, so i think this is currently unnessesary ? Where exactly was or is the missing symbol ?

As a sidenote: package_c_args is always autogenerated, and the library should only ever append to it, and then just use it. It should not be stored in general (there are the 2 special cases in edje_externals)

This revision now requires changes to proceed.Jul 6 2020, 8:06 AM