Page MenuHomePhabricator

Native Windows: Eina: Resolve bad comparison while using windows strerror_s
ClosedPublic

Authored by lucas on Jun 26 2020, 5:51 AM.

Details

Summary

strerror_s is the windows alternative of strerror_r used by EFL.

strerror_s never return the error code with the message as
strerror_r does, because of that, while comparing the first 14
characters of Unknown error to the message from unknown code 4096
(Unknown error) they were accusing being different - in UNIX this
works because the message returned is Unknown error 4096.
This error was noticeable at eina_error_test_failures test case.

This Diff adds the error code to the message in case of an `Unknown
error`, making the windows implementation compliant with UNIX.

Test Plan

EFL's native windows implamentation should fail at eina_error_test_failures
without this Diff.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lucas created this revision.Jun 26 2020, 5:51 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

lucas requested review of this revision.Jun 26 2020, 5:51 AM
vtorri accepted this revision.Jun 26 2020, 5:54 AM
This revision is now accepted and ready to land.Jun 26 2020, 5:54 AM
walac accepted this revision.Jun 26 2020, 6:20 AM
stefan_schmidt accepted this revision.Jun 26 2020, 8:16 AM
This revision was automatically updated to reflect the committed changes.