Page MenuHomePhabricator

Protect EINA_(UN)LIKELY with parenthesis around the expr
ClosedPublic

Authored by walac on Jul 2 2020, 2:38 PM.

Details

Summary

Without it an expression like !EINA_LIKELY(a && b) expands
!a && b

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
walac created this revision.Jul 2 2020, 2:38 PM
walac requested review of this revision.Jul 2 2020, 2:38 PM

It is important to note that this does happen in eo_base_class.c in _cb_desc_match.

cedric accepted this revision.Jul 2 2020, 3:04 PM
This revision is now accepted and ready to land.Jul 2 2020, 3:04 PM
vtorri accepted this revision.Jul 2 2020, 10:36 PM
bu5hm4n accepted this revision.Jul 3 2020, 12:08 AM
bu5hm4n requested changes to this revision.

Patch does not apply ...

This revision now requires changes to proceed.Jul 3 2020, 12:09 AM
bu5hm4n resigned from this revision.Jul 3 2020, 12:10 AM
This revision is now accepted and ready to land.Jul 3 2020, 12:10 AM
walac updated this revision to Diff 30816.Jul 3 2020, 7:06 AM

Fix patch to apply to HEAD

walac added a subscriber: bu5hm4n.Jul 3 2020, 7:06 AM

Patch does not apply ...

Fixed!

Closed by commit rEFLb767e286252d: Protect EINA_(UN)LIKELY with parenthesis around the expr (authored by walac, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 3 2020, 9:18 AM
This revision was automatically updated to reflect the committed changes.