Page MenuHomePhabricator

efl_ui_focus_manager: reduce the amount of relying on events
ClosedPublic

Authored by bu5hm4n on Wed, Jul 29, 3:08 AM.

Details

Summary

with this commit we are not replying on event invocations anymore, but
rather on direct flag observation in the focus manager itself.

This reduces the amount of events that are emitted as a consequence to
elements beeing marked dirty segnificantly.

startup time of elementary_test goes from 0.50 to 0.46s.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Wed, Jul 29, 3:08 AM
bu5hm4n requested review of this revision.Wed, Jul 29, 3:08 AM
stefan_schmidt added inline comments.Wed, Jul 29, 7:19 AM
src/lib/elementary/efl_ui_focus_manager.eo
100

$true here?

105

, after change?

src/lib/elementary/efl_ui_focus_manager_calc.c
88

Are we sure we do not need a init to EINA_FALSE for this? I just ask because we had it for dirty_added. If all paths are correct without the initial setting, its fine without.

Will update later or tomorrow :)

src/lib/elementary/efl_ui_focus_manager.eo
100

Jup

105

Jup

src/lib/elementary/efl_ui_focus_manager_calc.c
88

We need to init it to true. Since 0 invocations of border elements get happened. So if you ask initially if it changed, it should be true :) (which is happening in the constructor here)

bu5hm4n updated this revision to Diff 30914.Wed, Jul 29, 8:58 AM

address review comments

src/lib/elementary/efl_ui_focus_manager_calc.c
1122

obj is unused, says my compiler, and she is right :-)

Rest looks good now, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jul 31, 1:18 AM
Closed by commit rEFL8d034f08e832: efl_ui_focus_manager: reduce the amount of relying on events (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.