Page MenuHomePhabricator

evas_textblock: remove logically dead code
ClosedPublic

Authored by YOhoho on Thu, Jul 30, 11:44 PM.

Details

Summary

Since c->fmt is allocated and dereferenced in _layoutformat_push, if
c->fmt is NULL, this causes a crash before checking for NULL.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
YOhoho created this revision.Thu, Jul 30, 11:44 PM
YOhoho requested review of this revision.Thu, Jul 30, 11:44 PM
bu5hm4n accepted this revision.Fri, Jul 31, 1:12 AM
bu5hm4n added a subscriber: bu5hm4n.

For the record:

I checked if _layout_format_push shoudln't protect again something like that, but we never check the result of _layout_format_push anywhere.

This revision is now accepted and ready to land.Fri, Jul 31, 1:12 AM
Closed by commit rEFL42d525e15b9e: evas_textblock: remove logically dead code (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFri, Jul 31, 1:18 AM
This revision was automatically updated to reflect the committed changes.