Page MenuHomePhabricator

evas_textblock : Enhance new line as paragraph separator functionality
Needs ReviewPublic

Authored by AbdullehGhujeh on Aug 9 2020, 7:18 AM.



New line as paragraph separator feature only applied on the new text entered,
with this update, it should be applied also for already entered text.

Diff Detail

rEFL core/efl
No Linters Available
No Unit Test Coverage
Build Status
Buildable 17255
Build 11519: arc lint + arc unit
AbdullehGhujeh created this revision.Aug 9 2020, 7:18 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added:

AbdullehGhujeh requested review of this revision.Aug 9 2020, 7:18 AM
AbdullehGhujeh edited the summary of this revision. (Show Details)Aug 9 2020, 7:21 AM
AbdullehGhujeh added a reviewer: ali.alzyod.

remove comment

Should we update all cursors in textblock? I just try to use this with TextBox and notice the cursor is not in the right position


What about <br/> ?

ali.alzyod requested changes to this revision.Aug 9 2020, 11:50 PM
This revision now requires changes to proceed.Aug 9 2020, 11:50 PM

Add check for <br/>

AbdullehGhujeh marked an inline comment as done.Aug 19 2020, 3:45 AM

After investigating cursor issue
I have created the following task for it :

ali.alzyod added inline comments.Nov 25 2020, 9:01 AM

How about iterate using Format nodes, instead of checking every character?