evas_textblock : Enhance new line as paragraph separator functionality
Needs ReviewPublic
Actions

Authored by AbdullehGhujeh on Aug 9 2020, 7:18 AM.

Details

Reviewers

Summary

New line as paragraph separator feature only applied on the new text entered,
with this update, it should be applied also for already entered text.

Repository

rEFL core/efl

Branch

arcpatch-D12099

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17255
Build 11519: arc lint + arc unit

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

AbdullehGhujeh requested review of this revision.Aug 9 2020, 7:18 AM

remove comment

Should we update all cursors in textblock? I just try to use this with TextBox and notice the cursor is not in the right position

src/lib/evas/canvas/evas_object_textblock.c
8401	What about <br/> ?

ali.alzyod requested changes to this revision.Aug 9 2020, 11:50 PM

This revision now requires changes to proceed.Aug 9 2020, 11:50 PM

Add check for <br/>

After investigating cursor issue
I have created the following task for it : https://phab.enlightenment.org/T8792

src/lib/evas/canvas/evas_object_textblock.c
8408	How about iterate using Format nodes, instead of checking every character?

			Path	Packages
M			src/lib/evas/canvas/evas_object_textblock.c (29 lines)
M			src/tests/evas/evas_test_textblock.c (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31013	7d2f3e8		Aug 9 2020, 7:17 AM	★	★
Diff 2	31014	7d2f3e8	remove comment	Aug 9 2020, 7:22 AM	★	★
Diff 3	31042	7d2f3e8	Add check for <br/>	Aug 19 2020, 3:18 AM	★	★