Page MenuHomePhabricator

evas_textblock: Add check for NULL pointers after malloc
AcceptedPublic

Authored by Sara on Thu, Sep 3, 6:00 AM.

Details

Summary

Adding null-checks after memory is allocated to objects to ensure sufficient memory exists.

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D12130
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17315
Build 11578: arc lint + arc unit
Sara created this revision.Thu, Sep 3, 6:00 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Sara requested review of this revision.Thu, Sep 3, 6:00 AM
Sara edited the summary of this revision. (Show Details)Thu, Sep 3, 6:02 AM
Sara added a reviewer: ali.alzyod.
ali.alzyod added inline comments.Sun, Sep 6, 8:22 AM
src/lib/evas/canvas/evas_object_textblock.c
6807–6808

wrong indentation

6824–6825

wrong indentation

10254–10255

wrong indentation

10326–10327

wrong indentation

16279

wrong indentation

16280

buf is used here

16289

wrong indentation

16291

buf is used here

Sara updated this revision to Diff 31108.Mon, Sep 7, 12:50 AM

Updating as requested in the comments

Sara updated this revision to Diff 31110.Mon, Sep 7, 4:16 AM

Removing extra space after if

ali.alzyod accepted this revision.Thu, Sep 10, 1:27 AM

seems fine to me

This revision is now accepted and ready to land.Thu, Sep 10, 1:27 AM

_layout_get_hyphenationwrap also needs to protect against wordbreaks beeing NULL (as its now checked before).

Sara updated this revision to Diff 31131.Sun, Sep 13, 11:44 PM

Checking on line_breaks and word_breaks