Page MenuHomePhabricator

eo: fix gdb install dir
Needs ReviewPublic

Authored by Millak on Sat, Sep 5, 2:35 PM.

Details

Reviewers
bu5hm4n
Summary

We shouldn't assume that 'usr' is the install prefix.

Diff Detail

Repository
rEFL core/efl
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17297
Build 11561: arc lint + arc unit
Millak created this revision.Sat, Sep 5, 2:35 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Millak requested review of this revision.Sat, Sep 5, 2:35 PM

Mhm, there are a few things that are not right in the way it is done right now:

  1. false as argument to install_dir is deprecated, the entire configure file blog should be moved to the first if clause.
  2. the prefix of efl can be different to the prefix of gdb, (for me efl goes to /usr/local/ and gdb goes to /usr/, gdb loads /usr/local as well as /usr/), so dir_lib actaully needs to be gdb prefix here, not the one of efl.

Mhm, there are a few things that are not right in the way it is done right now:

  1. false as argument to install_dir is deprecated, the entire configure file blog should be moved to the first if clause.

so drop the else and just set the install_dir directly

  1. the prefix of efl can be different to the prefix of gdb, (for me efl goes to /usr/local/ and gdb goes to /usr/, gdb loads /usr/local as well as /usr/), so dir_lib actaully needs to be gdb prefix here, not the one of efl.

A quick check through one of my systems shows that glib and gstreamer both install to $PREFIX/share/gdb/auto-load/$PREFIX/lib/libfoo-gdb.py
As far as prefix of efl vs prefix of gdb I don't know if one is "more correct" than the other.

for comparison (on my Guix system):
/gnu/store/555921cimgx7dnmyrr2q4m36ccszp5nw-glib-2.62.6/share/gdb/auto-load/gnu/store/555921cimgx7dnmyrr2q4m36ccszp5nw-glib-2.62.6/lib/libgobject-2.0.so.0.6200.6-gdb.py
/gnu/store/53f531fnwplh9pg7vvjbrzpkszil0zay-efl-1.24.3/share/gdb/auto-load/usr/lib/libeo.so.1.24.3-gdb.py