Page MenuHomePhabricator

evas_textblock : Handle cursor correctly when inserting ps
Needs ReviewPublic

Authored by AbdullehGhujeh on Sun, Sep 6, 6:28 AM.

Details

Summary

This update should correctly update cursors that are on the same text node and after the cursor that are inserting the ps.
this should resolve T8792

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D12133
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17316
Build 11579: arc lint + arc unit
AbdullehGhujeh created this revision.Sun, Sep 6, 6:28 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

AbdullehGhujeh requested review of this revision.Sun, Sep 6, 6:28 AM
ali.alzyod added inline comments.Sun, Sep 6, 9:41 AM
src/lib/evas/canvas/evas_object_textblock.c
11472

what does our cursor mean ?

11572

this will loop over all cursors,
So it will update all cursors, regardless of there text-nodes (for example if a cursor is in the first textnode, and we are modifying the 4th textnode, what will happen?! )

ali.alzyod added inline comments.Thu, Sep 10, 2:13 AM
src/lib/evas/canvas/evas_object_textblock.c
11572

Ignore my comment, you already do the check-in _cursor_update_node

AbdullehGhujeh edited the summary of this revision. (Show Details)

update function docs

AbdullehGhujeh marked an inline comment as done.Mon, Sep 14, 1:45 AM