Page MenuHomePhabricator

Added the heif loader
Needs ReviewPublic

Authored by thierry1970 on Sep 8 2020, 8:01 AM.

Details

Summary

that supports images : *.heif, *hiec and *.avif I have disabled *.avif images, there is already a loader.

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D12135
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17385
Build 11647: arc lint + arc unit
thierry1970 created this revision.Sep 8 2020, 8:01 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

thierry1970 requested review of this revision.Sep 8 2020, 8:01 AM
thierry1970 retitled this revision from Added the heif loader that supports images : *.heif, *hiec and *.avif I have disabled *.avif images, there is already a loader. to Added the heif loader .
thierry1970 edited the summary of this revision. (Show Details)
thierry1970 updated this revision to Diff 31112.Sep 8 2020, 8:14 AM
thierry1970 retitled this revision from Added the heif loader to Added the heif loader.
  • file renaming.
vtorri added a subscriber: vtorri.Sep 8 2020, 9:39 AM
vtorri added inline comments.
meson_options.txt
192–193

i think that heif should be in the disabled-by-default loaders, heif is not a so common image format

src/lib/evas/file/evas_module.c
203

after gif :)

305

alphabetical order

src/lib/evas/meson.build
18

the loaders are stored alphabetically

vtorri added a comment.Sep 8 2020, 9:46 AM

do you plan to write a saver too ?

thierry1970 updated this revision to Diff 31113.Sep 8 2020, 2:22 PM
thierry1970 marked 3 inline comments as done.
  • alphabetical order

I just looked to see if it was possible.
My priority was the "loader", I look for the "saver".

meson_options.txt
192–193

This is the default format of ios 11.

  • file renaming.
  • Add mimetyes for heif and avif.
  • Fix build.

why was checkme deleted ?

src/lib/evas/file/evas_module.c
203

after gif again

305

after gif again

src/lib/evas/meson.build
18

after gif

thierry1970 marked 3 inline comments as done.
  • Fix alphabetical order.

Sorry I'm on the 1.24.3 (it's a mess on it and I report on the master). I fix it!

src/lib/evas/file/evas_module.c
203

Sorry I'm on the 1.24.3 (it's a mess on it and I report on the master). I fix it!

  • Revert delete checkme.

I thought "checkme" was present in folders without files.

i think i'll be able to test your patch this week-end

vtorri added a subscriber: raster.Oct 5 2020, 6:47 AM

@thierry1970 btw, something that is annoying is the license of libheif (found there : https://github.com/strukturag/libheif) : the license is LGPL v3, and not v2.
@raster do you htink the license is a problem ?

raster requested changes to this revision.Oct 5 2020, 8:46 AM

oooh. lgplv3 ... that'll be a problem for anyone shipping libheif... from our point of view it doesn't mater, but any system "Builder" (makes an os) now, if they want heif, essentially have to unlock the os and allow heif to be replaced.

my take - heif needs to be disabled by default and we need to note this in the README. it's on by default here so this needs to change.

This revision now requires changes to proceed.Oct 5 2020, 8:46 AM
vtorri added a comment.Oct 5 2020, 9:29 AM

or we can do like poppler, maybe ? using the generic loader

raster added a comment.Oct 5 2020, 3:30 PM

no even if generic the lgplv3 will still apply as i mentioned. being lplg - the license doesnt affect efl or apps using efl, but gpl3 or lgpl3 affects the entire os requiring any gpl/lgpl3 component be user-replacable.

vtorri added a comment.Oct 5 2020, 3:33 PM

ok. I have asked on libheif github if they can re-license the code to lgpl v2. Let's see if they accept or not

raster added a comment.Oct 6 2020, 3:37 AM

Chances of them re-licensing: 0.00001%. :) As I said - no need to make it a generic loader, but it does need to be off by default and an appropriate README entry describing what enabling it would mean for a system.

  • Disabled by default heif loaders
  • Add readme section Heif

Sorry, I didn't see your answer.
I don't receive notifications anymore, despite the settings.