Page MenuHomePhabricator

Added the heif loader
Needs ReviewPublic

Authored by thierry1970 on Tue, Sep 8, 8:01 AM.

Details

Reviewers
stefan_schmidt
Summary

that supports images : *.heif, *hiec and *.avif I have disabled *.avif images, there is already a loader.

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D12135
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17332
Build 11594: arc lint + arc unit
thierry1970 created this revision.Tue, Sep 8, 8:01 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

thierry1970 requested review of this revision.Tue, Sep 8, 8:01 AM
thierry1970 retitled this revision from Added the heif loader that supports images : *.heif, *hiec and *.avif I have disabled *.avif images, there is already a loader. to Added the heif loader .
thierry1970 edited the summary of this revision. (Show Details)
thierry1970 updated this revision to Diff 31112.Tue, Sep 8, 8:14 AM
thierry1970 retitled this revision from Added the heif loader to Added the heif loader.
  • file renaming.
vtorri added a subscriber: vtorri.Tue, Sep 8, 9:39 AM
vtorri added inline comments.
meson_options.txt
193

i think that heif should be in the disabled-by-default loaders, heif is not a so common image format

src/lib/evas/file/evas_module.c
203

after gif :)

305

alphabetical order

src/lib/evas/meson.build
18

the loaders are stored alphabetically

vtorri added a comment.Tue, Sep 8, 9:46 AM

do you plan to write a saver too ?

thierry1970 updated this revision to Diff 31113.Tue, Sep 8, 2:22 PM
thierry1970 marked 3 inline comments as done.
  • alphabetical order

I just looked to see if it was possible.
My priority was the "loader", I look for the "saver".

meson_options.txt
193

This is the default format of ios 11.

  • file renaming.
  • Add mimetyes for heif and avif.
  • Fix build.

why was checkme deleted ?

src/lib/evas/file/evas_module.c
203

after gif again

305

after gif again

src/lib/evas/meson.build
18

after gif

thierry1970 marked 3 inline comments as done.
  • Fix alphabetical order.

Sorry I'm on the 1.24.3 (it's a mess on it and I report on the master). I fix it!

src/lib/evas/file/evas_module.c
203

Sorry I'm on the 1.24.3 (it's a mess on it and I report on the master). I fix it!

  • Revert delete checkme.

I thought "checkme" was present in folders without files.