Page MenuHomePhabricator

call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0
ClosedPublic

Authored by n3rdopolis on Sun, Sep 13, 8:15 PM.

Details

Summary

All TTYs are on seat0, but not all seat0s have TTYs

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
n3rdopolis created this revision.Sun, Sep 13, 8:15 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

n3rdopolis requested review of this revision.Sun, Sep 13, 8:15 PM
devilhorns accepted this revision.Tue, Sep 15, 5:56 AM
This revision is now accepted and ready to land.Tue, Sep 15, 5:56 AM

Patch looks good, but I cannot apply it :( When I do 'git phab apply' on this, it complains because the patch contains no author email address ....

@devilhorns, @raster you want this in before the final release?

@devilhorns, @raster you want this in before the final release?

@stefan_schmidt I would like to get it in before final release, yes ...But I cannot get the patch to apply using 'git phab apply D12143' ... complains about patch missing author email and won't apply :(

this is not critical as well.. there are no such systems that we know about yet... they are theoretically possible... so it's not a burning red hot issue that must be solved asap.

@devilhorns I see.
@n3rdopolis did you upload the patch by pasting in a raw git diff? Or did your use the git phab or arc tools? We have seen this exact problem with the later variant.
If you can't switch to git phab or arc I would suggest that you send a link to the full git format-patch output so we can apply that one.

@raster I know, but since devilhorns already approved it I wondered if it should go in before or not.

Yeah I posted the raw diff. Let me figure out what I can do

n3rdopolis updated this revision to Diff 31144.Wed, Sep 16, 4:01 PM

@n3rdopolis Still the same problem. If you can'Ät use git phab or arc please upload the raw git format-patch elsewhere and post the link here.

You can get the raw diff just here by clicking above "download raw diff".

@n3rdopolis can we just use your mail address nerdopolis <bluescreen_avenger@verizon.net> for landing this ?

@bu5hm4n When I wrote raw diff what I really mean is the file diff plus metatdata like author, commit subject and message, date, etc

Oh okay sorry - my brain fully worked in phabricator terminology there :(

@bu5hm4n Sure, I am OK with that

Closed by commit rEFL57354e01ecdb: call sd_seat_can_tty to determine if ttys should be used, instead of hard… (authored by n3rdopolis, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFri, Sep 18, 2:49 AM
This revision was automatically updated to reflect the committed changes.