Not everyone has a system or libraries that need to conform with
Freedesktop standards, making efreet not necessary on them.
This patch solves this by making efreet an optional library.
Details
Details
- Reviewers
jptiz - Maniphest Tasks
- T8814: Make efreet optional
meson test -C build + run edje, evas and elementary examples to
see if nothing got weird.
Ref T8814
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Branch
- devs/jptiz/efreet-optional
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17340 Build 11602: arc lint + arc unit
Comment Actions
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
| meson_options.txt | ||
|---|---|---|
| 105 | i would set the value to true by default | |
Comment Actions
This is really not ideal. A few feature will be broken when porting an EFL apps that use eio/efl_io_model/filemanager to Windows. Isn't it possible to get some of the feature of efreet to work on the platform you are working on?
Comment Actions
I think I can see your point but it is not that clear to me how things would break. Could you give me an example just to understand?
| meson_options.txt | ||
|---|---|---|
| 105 | Indeed it makes more sense. | |
Comment Actions
For example, if you expect the mime type to be filled to take action, but it never is, then you application would be broken.
Comment Actions
I think removing efreet completely is misguided, the most important part for some platforms would be to remove efreetd and make caching minimal, a daemon for a whole EFL system makes sense, but not so much when your application is the only one using that daemon. So, I'd make a meson_option for efreetd=false and that makes efreet minimal and without efreetd.