Page MenuHomePhabricator

efreet: make efreet optional
AbandonedPublic

Authored by felipealmeida on Sep 18 2020, 1:30 PM.

Details

Reviewers
jptiz
Maniphest Tasks
T8814: Make efreet optional
Summary

Not everyone has a system or libraries that need to conform with
Freedesktop standards, making efreet not necessary on them.

This patch solves this by making efreet an optional library.

Test Plan

meson test -C build + run edje, evas and elementary examples to
see if nothing got weird.

Ref T8814

Diff Detail

Repository
rEFL core/efl
Branch
devs/jptiz/efreet-optional
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17338
Build 11600: arc lint + arc unit
jptiz created this revision.Sep 18 2020, 1:30 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

jptiz requested review of this revision.Sep 18 2020, 1:30 PM
vtorri added a subscriber: vtorri.Sep 18 2020, 1:42 PM
vtorri added inline comments.
meson_options.txt
105

i would set the value to true by default

This is really not ideal. A few feature will be broken when porting an EFL apps that use eio/efl_io_model/filemanager to Windows. Isn't it possible to get some of the feature of efreet to work on the platform you are working on?

jptiz added a comment.Sep 18 2020, 1:55 PM

This is really not ideal. A few feature will be broken when porting an EFL apps that use eio/efl_io_model/filemanager to Windows. Isn't it possible to get some of the feature of efreet to work on the platform you are working on?

I think I can see your point but it is not that clear to me how things would break. Could you give me an example just to understand?

meson_options.txt
105

Indeed it makes more sense.

This is really not ideal. A few feature will be broken when porting an EFL apps that use eio/efl_io_model/filemanager to Windows. Isn't it possible to get some of the feature of efreet to work on the platform you are working on?

I think I can see your point but it is not that clear to me how things would break. Could you give me an example just to understand?

For example, if you expect the mime type to be filled to take action, but it never is, then you application would be broken.

jptiz updated this revision to Diff 31162.Sep 18 2020, 2:52 PM

Let efreet enabled by default.

jptiz updated this revision to Diff 31163.Sep 18 2020, 3:15 PM
jptiz marked 2 inline comments as done.

Better variable naming for deps. Organizing a coulpe of #ifdefs.

I think removing efreet completely is misguided, the most important part for some platforms would be to remove efreetd and make caching minimal, a daemon for a whole EFL system makes sense, but not so much when your application is the only one using that daemon. So, I'd make a meson_option for efreetd=false and that makes efreet minimal and without efreetd.

IOW, lets close this and bring a more appropriate patch soon

felipealmeida commandeered this revision.Sep 21 2020, 9:20 AM
felipealmeida abandoned this revision.
felipealmeida added a reviewer: jptiz.