Details
- Reviewers
HarmlessBug
Diff Detail
- Repository
- rE core/enlightenment
- Branch
- harmlessbug
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17362 Build 11624: arc lint + arc unit
The logic is ok ... But I DONT like how this LOOKS....
managed = xyz_function.....
If !mananged goto town....
I would rather this LONG WINDED function be Properly returned, and Then Checked....Please make this code a little bit cleaner....
We are trading One bad thing for just Another here ..... Please clean this UP properly.....then It will go In....
Happy to Aprovie this .. but it needs to Look better... Easier to Read.....
Get the return of the Function, Check that ... And then it Can Go In
Stop trying to make it More difficult to read...and just read it....
It is all 0 & 1 right ?
Good report tho ....better than the average bear.....
Clean this up a little and I will put it in,..
Guess I will do it myself....make it proper, then submit it.....
No Answers from patch Author.....
Not hard to check a return/
this isnt wrong.. it's just a bit ugly... maybe just managed -> int and if (managed > 0) in later if's... :)