Page MenuHomePhabricator

evas/textblock: apply style paddings in fit calculation
ClosedPublic

Authored by id213sin on Oct 20 2020, 10:04 PM.

Details

Summary

The style paddings should be calculated for fitting text into
the given object's size.

Test Plan
  1. Put shadow effect in your style string.

"... style=shadow,far_bottom shadow_color=#000 ..."

  1. Apply fit option( and ellipsis to see how it goes wrong without this patch.)
  1. See results.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
id213sin created this revision.Oct 20 2020, 10:04 PM
id213sin requested review of this revision.Oct 20 2020, 10:04 PM
woohyun accepted this revision.Oct 20 2020, 10:48 PM

I think this looks proper modification.

@ali.alzyod
Could you do dual-check and give feedback if necessary ?

This revision is now accepted and ready to land.Oct 20 2020, 10:48 PM
ali.alzyod accepted this revision.Oct 21 2020, 8:47 PM

This is right

This revision was automatically updated to reflect the committed changes.