Page MenuHomePhabricator

benchmark: Remove unnecessary import and export macros from benchmark executables

Authored by felipealmeida on Dec 4 2020, 5:50 AM.



Benchmark executables do not need to export and import symbols because
they are not loaded by other executables. Removing is important because
EAPI will be removed in some later commit and would break benchmark

The Rationale

This patch is from a series of patches to rename EAPI symbols to
specific library DSOs.

EAPI was designed to be able to pass
__attribute__ ((visibility ("default"))) for symbols with
GCC, which would mean that even if -fvisibility=hidden was used
when compiling the library, the needed symbols would get exported.

MSVC almost works like GCC (or mingw) in which you can
declare everything as export and it will just work (slower, but
it will work). But there's a caveat: global variables will not
work the same way for MSVC, but works for mingw and GCC.

For global variables (as opposed to functions), MSVC requires
correct DSO visibility for MSVC: instead of declaring a symbol as
export for everything, you need to declare it as import when
importing from another DSO and export when defining it locally.

With current EAPI definitions, we get the following example
working in mingw and MSVC (observe it doesn't define any global
variables as exported symbols).

Example 1:

EAPI void foo(void);

EAPI void bar()


EAPI void foo()
  printf ("foo\n");

This works fine with API defined as __declspec(dllexport) in both
cases and for gcc defining as

However, the following:
Example 2:


EAPI extern int foo;
EAPI void foobar(void);

EAPI void bar()
  foo = 5;


EAPI int foo = 0;
EAPI void foobar()
  printf ("foo %d\n", foo);

This will work on mingw but will not work for MSVC. And that's why
LIBAPI is the only solution that works for MSVC.

Co-authored-by: João Paulo Taylor Ienczak Zanette <>
Co-authored-by: Lucas Cavalcante de Sousa <>
Co-authored-by: Ricardo Campos <>

Diff Detail

rEFL core/efl
No Linters Available
No Unit Test Coverage
Build Status
Buildable 17417
Build 11679: arc lint + arc unit
felipealmeida created this revision.Dec 4 2020, 5:50 AM
felipealmeida requested review of this revision.Dec 4 2020, 5:50 AM
vtorri accepted this revision.Dec 4 2020, 11:13 PM

seems good

This revision is now accepted and ready to land.Dec 4 2020, 11:13 PM
This revision was automatically updated to reflect the committed changes.