Page MenuHomePhabricator

eo_base_class: Avoid useless memory alloc
ClosedPublic

Authored by CHAN on Dec 8 2020, 8:35 PM.

Details

Summary

The pd->ext will be NULL when the target object on invalidate state or edje object or isolated object etc..

In above case, If data is NULL and ext is not needed, it seems there is no need to create a node.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
CHAN created this revision.Dec 8 2020, 8:35 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

CHAN requested review of this revision.Dec 8 2020, 8:35 PM
CHAN edited the summary of this revision. (Show Details)Dec 8 2020, 8:38 PM
CHAN added reviewers: raster, cedric, Hermet.
Hermet accepted this revision.Dec 23 2020, 6:46 PM
This revision is now accepted and ready to land.Dec 23 2020, 6:46 PM
Closed by commit rEFLed0c46fa3b91: eo_base_class: Avoid useless memory alloc (authored by Woochanlee <wc0917.lee@samsung.com>, committed by Hermet). · Explain WhyDec 23 2020, 6:47 PM
This revision was automatically updated to reflect the committed changes.