Page MenuHomePhabricator

ecore_audio: Rename EAPI macro to ECORE_AUDIO_API in Ecore Audio library
ClosedPublic

Authored by felipealmeida on Dec 14 2020, 6:53 AM.

Details

Summary

Patch from a series of patches to rename EAPI symbols to specific
library DSOs.

The Rationale

This patch is from a series of patches to rename EAPI symbols to
specific library DSOs.

EAPI was designed to be able to pass
__attribute__ ((visibility ("default"))) for symbols with
GCC, which would mean that even if -fvisibility=hidden was used
when compiling the library, the needed symbols would get exported.

MSVC almost works like GCC (or mingw) in which you can
declare everything as export and it will just work (slower, but
it will work). But there's a caveat: global variables will not
work the same way for MSVC, but works for mingw and GCC.

For global variables (as opposed to functions), MSVC requires
correct DSO visibility for MSVC: instead of declaring a symbol as
export for everything, you need to declare it as import when
importing from another DSO and export when defining it locally.

With current EAPI definitions, we get the following example
working in mingw and MSVC (observe it doesn't define any global
variables as exported symbols).

Example 1:
dll1:

EAPI void foo(void);

EAPI void bar()
{
  foo();
}

dll2:

EAPI void foo()
{
  printf ("foo\n");
}

This works fine with API defined as __declspec(dllexport) in both
cases and for gcc defining as
__atttribute__((visibility("default"))).

However, the following:
Example 2:

dll1:

EAPI extern int foo;
EAPI void foobar(void);

EAPI void bar()
{
  foo = 5;
  foobar();
}

dll2:

EAPI int foo = 0;
EAPI void foobar()
{
  printf ("foo %d\n", foo);
}

This will work on mingw but will not work for MSVC. And that's why
LIBAPI is the only solution that works for MSVC.

Co-authored-by: João Paulo Taylor Ienczak Zanette <jpaulotiz@gmail.com>
Co-authored-by: Lucas Cavalcante de Sousa <lucks.sousa@gmail.com>
Co-authored-by: Ricardo Campos <ricardo.campos@expertise.dev>

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
felipealmeida created this revision.Dec 14 2020, 6:53 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

felipealmeida requested review of this revision.Dec 14 2020, 6:53 AM
vtorri added a subscriber: vtorri.Dec 14 2020, 6:59 AM
vtorri added inline comments.
src/lib/ecore_audio/ecore_audio_api.h
19 ↗(On Diff #31303)

elif :)

Remove api.h file

lucas accepted this revision.Dec 15 2020, 4:58 AM
This revision is now accepted and ready to land.Dec 15 2020, 4:58 AM
vtorri accepted this revision.Dec 15 2020, 6:19 AM

it compiles and elm_test plays sound, so ok

This revision was automatically updated to reflect the committed changes.