Page MenuHomePhabricator

edje: get an Edje real part when only a file is loaded
Needs RevisionPublic

Authored by id213sin on Dec 16 2020, 9:25 PM.

Details

Reviewers
zmike
devilhorns
Summary

It is a missing change from the following patch.
commit-id: f5d3f575c6b77e882ec26f9910276cf9ab1c299d

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17445
Build 11707: arc lint + arc unit
id213sin created this revision.Dec 16 2020, 9:25 PM
id213sin requested review of this revision.Dec 16 2020, 9:25 PM
devilhorns requested changes to this revision.Tue, Jan 19, 1:25 PM
devilhorns added a subscriber: devilhorns.
devilhorns added inline comments.
src/lib/edje/edje_util.c
4231

With this patch, if 'rp' is never set above (because there is not ed->file) than all of these subsequent dereferences are going to crash ... eg: rp->drag->size.x, etc, etc will all cause crashes as 'rp' is declared NULL at the top.

ie: What happens when this function is called, but ed->file is NULL ??? Any access to 'rp' below is going to crash....

This revision now requires changes to proceed.Tue, Jan 19, 1:25 PM