Page MenuHomePhabricator

eeze walk: fix a memory leaking
ClosedPublic

Authored by akanad on Dec 22 2020, 10:48 PM.

Details

Summary

there is a memory leak in a logic for walking along child-parent relation,
in case of device_get_sysattr_value failure.
this patch fixes the leak.

Change-Id: I95e9484b1549d1c794ec529c995af33da9b8a0ee

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akanad created this revision.Dec 22 2020, 10:48 PM
akanad requested review of this revision.Dec 22 2020, 10:48 PM
vtorri added a subscriber: vtorri.
vtorri added inline comments.
src/lib/eeze/eeze_udev_walk.c
52

isn't it clearer to have these commands inside the for loop body ?

This comment was removed by raster.
raster added a subscriber: raster.Mon, Jan 25, 12:49 AM
raster accepted this revision.Mon, Jan 25, 12:55 AM

will make the suggested changes too

This revision is now accepted and ready to land.Mon, Jan 25, 12:55 AM
This revision was automatically updated to reflect the committed changes.