Page MenuHomePhabricator

ecore_con: Rename EAPI macro to ECORE_CON_API in Ecore Con library
ClosedPublic

Authored by felipealmeida on Mon, Dec 28, 4:34 AM.

Details

Summary

Patch from a series of patches to rename EAPI symbols to specific
library DSOs.

EAPI was designed to be able to pass
__attribute__ ((visibility ("default"))) for symbols with
GCC, which would mean that even if -fvisibility=hidden was used
when compiling the library, the needed symbols would get exported.

MSVC almost works like GCC (or mingw) in which you can
declare everything as export and it will just work (slower, but
it will work). But there's a caveat: global variables will not
work the same way for MSVC, but works for mingw and GCC.

For global variables (as opposed to functions), MSVC requires
correct DSO visibility for MSVC: instead of declaring a symbol as
export for everything, you need to declare it as import when
importing from another DSO and export when defining it locally.

With current EAPI definitions, we get the following example
working in mingw and MSVC (observe it doesn't define any global
variables as exported symbols).

Example 1:
dll1:

EAPI void foo(void);

EAPI void bar()
{
  foo();
}

dll2:

EAPI void foo()
{
  printf ("foo\n");
}

This works fine with API defined as __declspec(dllexport) in both
cases and for gcc defining as
__atttribute__((visibility("default"))).

However, the following:
Example 2:

dll1:

EAPI extern int foo;
EAPI void foobar(void);

EAPI void bar()
{
  foo = 5;
  foobar();
}

dll2:

EAPI int foo = 0;
EAPI void foobar()
{
  printf ("foo %d\n", foo);
}

This will work on mingw but will not work for MSVC. And that's why
EAPI is the only solution that worked for MSVC.

Co-authored-by: João Paulo Taylor Ienczak Zanette <jpaulotiz@gmail.com>
Co-authored-by: Ricardo Campos <ricardo.campos@expertise.dev>
Co-authored-by: Lucas Cavalcante de Sousa <lucks.sousa@gmail.com>

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
felipealmeida created this revision.Mon, Dec 28, 4:34 AM
felipealmeida requested review of this revision.Mon, Dec 28, 4:34 AM
felipealmeida edited the summary of this revision. (Show Details)Mon, Dec 28, 4:37 AM
felipealmeida edited the summary of this revision. (Show Details)

do you have an example to test ecore_con ?

other than that, it compiles. I'm waiting for an example

vtorri accepted this revision.Mon, Dec 28, 8:08 AM

ecore_con_client|server_example.exe is behaving the same with and without patch, so ok

This revision is now accepted and ready to land.Mon, Dec 28, 8:08 AM
This revision was automatically updated to reflect the committed changes.