Page MenuHomePhabricator

modules: Rename EAPI macro to MODAPI for modules
AcceptedPublic

Authored by felipealmeida on Fri, Jan 1, 12:53 PM.

Details

Summary

Patch from a series of patches to rename EAPI symbols to specific
library DSOs.

The Rationale

EAPI was designed to be able to pass
__attribute__ ((visibility ("default"))) for symbols with
GCC, which would mean that even if -fvisibility=hidden was used
when compiling the library, the needed symbols would get exported.

MSVC almost works like GCC (or mingw) in which you can
declare everything as export and it will just work (slower, but
it will work). But there's a caveat: global variables will not
work the same way for MSVC, but works for mingw and GCC.

For global variables (as opposed to functions), MSVC requires
correct DSO visibility for MSVC: instead of declaring a symbol as
export for everything, you need to declare it as import when
importing from another DSO and export when defining it locally.

With current EAPI definitions, we get the following example
working in mingw and MSVC (observe it doesn't define any global
variables as exported symbols).

Example 1:
dll1:

EAPI void foo(void);

EAPI void bar()
{
  foo();
}

dll2:

EAPI void foo()
{
  printf ("foo\n");
}

This works fine with API defined as __declspec(dllexport) in both
cases and for gcc defining as
__atttribute__((visibility("default"))).

However, the following:
Example 2:

dll1:

EAPI extern int foo;
EAPI void foobar(void);

EAPI void bar()
{
  foo = 5;
  foobar();
}

dll2:

EAPI int foo = 0;
EAPI void foobar()
{
  printf ("foo %d\n", foo);
}

This will work on mingw but will not work for MSVC. And that's why
EAPI is the only solution that worked for MSVC.

Co-authored-by: João Paulo Taylor Ienczak Zanette <jpaulotiz@gmail.com>
Co-authored-by: Ricardo Campos <ricardo.campos@expertise.dev>
Co-authored-by: Lucas Cavalcante de Sousa <lucks.sousa@gmail.com>

Diff Detail

Repository
rEFL core/efl
Branch
devs/felipealmeida/modules-eapi (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17456
Build 11718: arc lint + arc unit
felipealmeida created this revision.Fri, Jan 1, 12:53 PM
felipealmeida requested review of this revision.Fri, Jan 1, 12:53 PM
lucas added inline comments.Tue, Jan 5, 4:47 AM
src/modules/evas/engines/gl_generic/evas_ector_gl.h
5

This one doesn't have # ifndef EFL_MODULE_STATIC is it as you expected @felipealmeida ?

felipealmeida marked an inline comment as done.Wed, Jan 6, 8:13 AM
felipealmeida added inline comments.
src/modules/evas/engines/gl_generic/evas_ector_gl.h
5

There wasn't this option before. So I just kept the same behavior.

This comment was removed by raster.
This comment was removed by raster.
raster added a subscriber: raster.Tue, Jan 12, 1:39 AM
smith78899 accepted this revision.Sat, Jan 23, 7:08 AM
smith78899 added a subscriber: smith78899.
This comment was removed by smith78899.
This revision is now accepted and ready to land.Sat, Jan 23, 7:08 AM