Details

Reviewers

raster
devilhorns

Test Plan

compilation

Diff Detail

Branch

vtorri_meson

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17486
Build 11748: arc lint + arc unit

vtorri created this revision.Jan 29 2021, 9:07 AM

Harbormaster completed remote builds in B17469: Diff 31354.Jan 29 2021, 9:07 AM

vtorri requested review of this revision.Jan 29 2021, 9:07 AM

devilhorns requested changes to this revision.Mon, Feb 1, 5:35 AM

devilhorns added inline comments.

data/themes/meson.build
7	etui ??
13	etui ?
src/lib/meson.build
14	This line causes a Meson build failure when I execute it here: src/lib/meson.build:13:0: ERROR: C shared or static library 'ws2_32' not found

This revision now requires changes to proceed.Mon, Feb 1, 5:35 AM

fix build issue on non Windows OS

Harbormaster completed remote builds in B17472: Diff 31359.Mon, Feb 1, 5:51 AM

vtorri marked 2 inline comments as done.Mon, Feb 1, 5:51 AM

log723 KBDownload

It starts to build now :) but getting lots of build issues ... I've attached a log of the build output

missing new line

Harbormaster completed remote builds in B17473: Diff 31360.Mon, Feb 1, 2:06 PM

@vtorri This is looking Soo much better....

meson.build
8	c99? Is this ok ?
86	-g ?
104	remove commented blocks when done please

vtorri added inline comments.Mon, Feb 1, 10:02 PM

meson.build
8	it's needed for variadic macro (like EINA_LOG_ERROR)
86	normally, the buildtype option with value debugoptimized or debug should pass -g
104	of course

remove c99 standard

Harbormaster completed remote builds in B17483: Diff 31375.Fri, Feb 12, 7:53 AM

remove compiler error flag

Harbormaster completed remote builds in B17484: Diff 31376.Fri, Feb 12, 8:45 AM

devilhorns accepted this revision.Fri, Feb 12, 8:47 AM

This revision is now accepted and ready to land.Fri, Feb 12, 8:47 AM

add private libs -lws2_32 to express.pc on Windows

Harbormaster completed remote builds in B17485: Diff 31377.Fri, Feb 12, 9:04 AM

fix typo

Harbormaster completed remote builds in B17486: Diff 31378.Fri, Feb 12, 9:27 AM

@vtorri A huge Thank You for your hard work here !!!

devilhorns awarded a token.Fri, Feb 12, 9:33 AM

		Path
A	M	data/desktop/meson.build (10 lines)
A	M	data/fonts/meson.build (31 lines)
A	M	data/images/meson.build (5 lines)
A	M	data/themes/meson.build (23 lines)
A	M	meson.build (148 lines)
A	M	meson_options.txt (6 lines)
A	M	src/bin/meson.build (53 lines)
A	M	src/lib/meson.build (51 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31354	eefa100		Jan 29 2021, 9:07 AM	★	★
Diff 2	31359	eefa100	fix build issue on non Windows OS	Mon, Feb 1, 5:50 AM	★	★
Diff 3	31360	eefa100	missing new line	Mon, Feb 1, 2:05 PM	★	★
Diff 4	31375	eefa100	remove c99 standard	Fri, Feb 12, 7:52 AM	★	★
Diff 5	31376	eefa100	remove compiler error flag	Fri, Feb 12, 8:45 AM	★	★
Diff 6	31377	eefa100	add private libs -lws2_32 to express.pc on Windows	Fri, Feb 12, 9:04 AM	★	★
Diff 7	31378	eefa100	fix typo	Fri, Feb 12, 9:27 AM	★	★

meson build system
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 31378

data/desktop/meson.build

data/fonts/meson.build

data/images/meson.build

data/themes/meson.build

meson.build

meson_options.txt

src/bin/meson.build

src/lib/meson.build

meson build systemClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 31378

data/desktop/meson.build

data/fonts/meson.build

data/images/meson.build

data/themes/meson.build

meson.build

meson_options.txt

src/bin/meson.build

src/lib/meson.build

meson build system
ClosedPublic
Actions

Revision Contents
Changeset List