Page MenuHomePhabricator

Boost compatibility with recent libtorrent versions.
ClosedPublic

Authored by rafspiny on May 21 2021, 2:39 PM.

Details

Summary

Since libtorrent 1.2.0.0, several things have changed:

  • Session are handled differently. Must use get_settings() instead of calling settings()
  • Also set_settings() has been removed. Now apply_settings() must be used.
  • The way proxies are stored has changed too.

Everything has been made backwords compatible.

Plus, I took the liberty of getting rid of the cgi module.
cgi.escape() as been deprecated since Python 3.2
So I replaced it with the html module, as recommended from the Python documentation:

Fixes #T8885

Diff Detail

Branch
fix/T8885
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17521
Build 11783: arc lint + arc unit
rafspiny requested review of this revision.May 21 2021, 2:39 PM
rafspiny created this revision.
ProhtMeyhet resigned from this revision.May 23 2021, 3:40 AM
ProhtMeyhet added a subscriber: ali.alzyod.

I've got no clue about libtorrent, so I recuse myself from here. Maybe @ali.alzyod ?

raster accepted this revision.May 23 2021, 11:40 AM
This revision is now accepted and ready to land.May 23 2021, 11:40 AM
raster closed this revision.May 23 2021, 11:43 AM
raster mentioned this in T8885: Epour not working.

c7264e9ed5eb1725d926cbc76324bfbb9bfc6da9

kuuko awarded a token.Wed, May 26, 2:09 AM