Page MenuHomePhabricator

Content Fit Enhancment
ClosedPublic

Authored by ali.alzyod on Aug 14 2021, 12:03 PM.

Details

Summary

Allow user to get currently used font size when Text Fitting is enabled.

previously, the user can not know what is current font size, he only specifies font size ranges, and the algorithm internally decides suitable font size.
with this change, the user has the ability to know the font size, that the fitting algorithm has picked

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Aug 14 2021, 12:03 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Aug 14 2021, 12:03 PM
raster requested changes to this revision.Aug 14 2021, 1:41 PM
raster added a subscriber: raster.
raster added inline comments.
src/bin/elementary/test_label.c
435

Just style - we dont use camelCase in efl, but use underscore_notation style instead :)

src/lib/evas/canvas/evas_object_textblock.c
18057

Formatting-wise the below function juts does not fit. it looks out of place and makes reading code harder.

e.g. it does:

if (x) {
   y;
}

instead of

if (x)
  {
     y;
  }

also '*o' vs. '* fc' (space vs no space). no space after 'if' but rest of efl uses a space after if etc. ... :)

src/lib/evas/canvas/evas_textblock_legacy.h
1150

Can you add a @since 1.26

so people know the api is there since efl 1.26

This revision now requires changes to proceed.Aug 14 2021, 1:41 PM
ali.alzyod updated this revision to Diff 31466.Aug 21 2021, 7:21 AM

change camel case to underscore

ali.alzyod marked 3 inline comments as done.Aug 21 2021, 7:22 AM
ali.alzyod updated this revision to Diff 31467.Aug 21 2021, 7:24 AM

remove unused if condition

ali.alzyod edited the summary of this revision. (Show Details)Aug 21 2021, 7:28 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Aug 30, 11:14 AM
This revision was automatically updated to reflect the committed changes.