Page MenuHomePhabricator
Differential D12291

Switch to using explicit dependency func instead of using find_library
ClosedPublic
Actions

Authored by JoshStrobl on Sep 15 2021, 3:26 PM.

Details

Reviewers
billiob
Commits
rTRM2483873333b8: Switch to using explicit dependency func instead of using find_library
Summary

This fixes intl detection (under Solus, x86_64-solus-linux-gcc (Solus) 11.2.0).

Test Plan
  1. Compiled terminology without patch, failed to find intl and would not include gettext po files.
  2. Compiled with patch, successfully found intl.

Tested against efl 1.25.1 with terminology 1.9.0. Meson release is 1.59.1.

Diff Detail

Repository
rTRM apps/terminology
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
JoshStrobl requested review of this revision.Sep 15 2021, 3:26 PM
JoshStrobl created this revision.
billiob accepted this revision.Sep 19 2021, 12:37 PM
This revision is now accepted and ready to land.Sep 19 2021, 12:37 PM
Closed by commit rTRM2483873333b8: Switch to using explicit dependency func instead of using find_library (authored by JoshStrobl, committed by billiob). · Explain WhySep 19 2021, 12:40 PM
This revision was automatically updated to reflect the committed changes.
billiob added a comment.Sep 22 2021, 2:01 PM

I've done some changes to make it still work on some distro I use. Could you please test latest branch?

JoshStrobl added a comment.Sep 24 2021, 1:20 PM
In D12291#235031, @billiob wrote:

I've done some changes to make it still work on some distro I use. Could you please test latest branch?

Latest changes break intl detection again.

JoshStrobl added a comment.Thu, Sep 30, 1:04 PM
In D12291#235043, @billiob wrote:

@JoshStrobl is it better now?

Can confirm that rTRMf11b69882808251577938fe8d520de4ad41a896c fixed it. Thanks!

Revision Contents
Changeset List

PathPackages
Mmeson.build (2 lines)

Diff 31474

View Options

meson.build

Loading...