Page MenuHomePhabricator

Ensure we check for the correct minimum rsvg version for rsvg_handle_get_intrinsic_size_in_pixels
ClosedPublic

Authored by JoshStrobl on Sep 22 2021, 8:56 AM.

Details

Summary

In commit cbcf5bc64a90306c82f0eb99ae43b5f52c122f71, newer librsvg APIs were used that are not available in versions between 2.36.0 and 2.50.0, e.g. rsvg_handle_get_intrinsic_size_in_pixels which was included in 2.51.x.

This has been resolved by adding a HAVE_SVG_2_51 and using it for both rsvg_handle_get_intrinsic_size_in_pixels and rsvg_handle_render_document, though the later technically landed in 2.46.0.

Test Plan

Built efl against librsvg 2.52.0, provided patch to individually having compilation issues against 2.50.3.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
JoshStrobl created this revision.Sep 22 2021, 8:56 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

JoshStrobl requested review of this revision.Sep 22 2021, 8:56 AM
devilhorns accepted this revision.Sep 22 2021, 12:37 PM
This revision is now accepted and ready to land.Sep 22 2021, 12:37 PM
This revision was automatically updated to reflect the committed changes.