Details

Reviewers

Summary

add jxl loader and saver to Evas.

Test Plan

Entice for loading, animated jxl files or not
some conformances files : https://github.com/libjxl/conformance/tree/master/testcases

Diff Detail

Repository

rEFL core/efl

Branch

vtorri_jxl

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17591
Build 11853: arc lint + arc unit

vtorri created this revision.Dec 21 2021, 12:22 PM

Herald added a project: efl. · View Herald TranscriptDec 21 2021, 12:22 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

Harbormaster completed remote builds in B17567: Diff 31508.Dec 21 2021, 12:22 PM

vtorri requested review of this revision.Dec 21 2021, 12:22 PM

i need to change a bit the data() cb

so wait a bit before applying

Formatting

Harbormaster completed remote builds in B17587: Diff 31537.Apr 26 2022, 12:43 AM

formatting

Harbormaster completed remote builds in B17588: Diff 31538.Apr 26 2022, 5:49 AM

formatting

Harbormaster completed remote builds in B17589: Diff 31539.Apr 26 2022, 6:46 AM

factorize data callback

Harbormaster completed remote builds in B17590: Diff 31540.Apr 28 2022, 6:09 AM

a few minor changes (inline comments :)

src/modules/evas/image_loaders/jxl/evas_image_load_jxl.c
269	there is some junk character between JXL_BIG_ENDIAN and ; (i see a box here - some whitespace problem?)
399	eek bad indenting here. :)

This revision now requires changes to proceed.Apr 28 2022, 8:12 AM

formatting and remove junk character

@raster done

Harbormaster completed remote builds in B17591: Diff 31541.Apr 28 2022, 8:52 AM

accepted

raster abandoned this revision.Apr 28 2022, 9:07 AM

		Path
M		meson_options.txt (4 lines)
M		po/POTFILES.in (1 line)
M		src/lib/evas/common/evas_image_load.c (4 lines)
M		src/lib/evas/common/evas_image_save.c (2 lines)
M		src/lib/evas/file/evas_module.c (8 lines)
M		src/lib/evas/meson.build (4 lines)
A	M	src/modules/evas/image_loaders/jxl/evas_image_load_jxl.c (526 lines)
A	M	src/modules/evas/image_savers/jxl/evas_image_save_jxl.c (213 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31508	4f15af9		Dec 21 2021, 12:22 PM	★	★
Diff 2	31537	4f15af9	Formatting	Apr 26 2022, 12:43 AM	★	★
Diff 3	31538	4f15af9	formatting	Apr 26 2022, 5:49 AM	★	★
Diff 4	31539	4f15af9	formatting	Apr 26 2022, 6:45 AM	★	★
Diff 5	31540	4f15af9	factorize data callback	Apr 28 2022, 6:09 AM	★	★
Diff 6	31541	4f15af9	formatting and remove junk character	Apr 28 2022, 8:44 AM	★	★

Evas: add jxl loader and saver
AbandonedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 31541

meson_options.txt

po/POTFILES.in

src/lib/evas/common/evas_image_load.c

src/lib/evas/common/evas_image_save.c

src/lib/evas/file/evas_module.c

src/lib/evas/meson.build

src/modules/evas/image_loaders/jxl/evas_image_load_jxl.c

src/modules/evas/image_savers/jxl/evas_image_save_jxl.c

Evas: add jxl loader and saverAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 31541

meson_options.txt

po/POTFILES.in

src/lib/evas/common/evas_image_load.c

src/lib/evas/common/evas_image_save.c

src/lib/evas/file/evas_module.c

src/lib/evas/meson.build

src/modules/evas/image_loaders/jxl/evas_image_load_jxl.c

src/modules/evas/image_savers/jxl/evas_image_save_jxl.c

Evas: add jxl loader and saver
AbandonedPublic
Actions

Revision Contents
Changeset List