Page MenuHomePhabricator

Efl.Gfx.Path: Remove unnecessary optimization code for small arc
ClosedPublic

Authored by jsuya on Jan 10 2022, 8:16 PM.

Details

Summary

This condition(optimization) is not a step suggested by arc implementation.
https://www.w3.org/TR/SVG11/implnote.html#ArcCorrectionOutOfRangeRadii (Step2)
This code is useful if the arc is too small to represent.
However, scaling often occurs in vectors, which can create unnecessary problems.

Test Plan

SVG Image

<svg viewBox="0 0 50 50" height="50" width="50">
<path d="M32.41,20.49a.41.41,0,1,1-.41-.42A.41.41,0,0,1,32.41,20.49Z" transform="translate(-70, -50) scale(3.3)" fill="#020202"/>
</svg>

image file


result

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Jan 10 2022, 8:16 PM
jsuya requested review of this revision.Jan 10 2022, 8:16 PM
jsuya edited the test plan for this revision. (Show Details)Jan 10 2022, 8:18 PM
Hermet accepted this revision.Jan 11 2022, 6:32 PM

verified sample resource has been fixed with this patch.

This revision is now accepted and ready to land.Jan 11 2022, 6:32 PM
This revision was automatically updated to reflect the committed changes.