Page MenuHomePhabricator

vg_common_svg: Fix when the number of polygon points is odd
ClosedPublic

Authored by jsuya on Mon, Jan 10, 10:31 PM.

Details

Summary

If the number of points is odd, an overflow occurs in array[i+1].

Test Plan

Test Svg image

<svg xmlns="http://www.w3.org/2000/svg" id="svg1" viewBox="0 0 200 200">
    <title>Not enough points</title>
    <desc>Must contain at least 4 points</desc>

    <polygon id="polygon1" points="20 40 160 40 10" fill="none" stroke="red"/>

    <!-- image frame -->
    <rect id="frame" x="1" y="1" width="198" height="198" fill="none" stroke="black"/>
</svg>

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17575
Build 11837: arc lint + arc unit
jsuya created this revision.Mon, Jan 10, 10:31 PM
jsuya requested review of this revision.Mon, Jan 10, 10:31 PM
Hermet accepted this revision.Tue, Jan 11, 6:35 PM

looks more safety.

This revision is now accepted and ready to land.Tue, Jan 11, 6:35 PM
Hermet closed this revision.Tue, Jan 11, 6:35 PM