Page MenuHomePhabricator

T2274: Fix trivial use-after-free in mixer/pa.c
AbandonedPublic

Authored by c on Apr 7 2015, 2:20 PM.

Details

Summary

Don't use memory after freeing it.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
c updated this revision to Diff 5275.Apr 7 2015, 2:20 PM
c retitled this revision from to T2274: Fix trivial use-after-free in mixer/pa.c.
c updated this object.
c edited the test plan for this revision. (Show Details)
c added a reviewer: raster.
c added a subscriber: enlightenment-git.
zmike requested changes to this revision.Apr 7 2015, 2:28 PM
zmike added a reviewer: zmike.
zmike added a subscriber: zmike.

Author does not appear to have correctly configured either git or arcanist; patch has no authorship data.

This revision now requires changes to proceed.Apr 7 2015, 2:28 PM
c added a comment.Apr 7 2015, 2:37 PM

Are you kidding me? It's completely trivial and you can credit yourself if you like. This patch is released into the public domain or MIT-licensed if you live somewhere that the public domain doesn't exist.

Else: Conrad Meyer <cse.cem@gmail.com>.

zmike added a comment.Apr 7 2015, 3:10 PM
In D2301#9, @c wrote:

Are you kidding me? It's completely trivial and you can credit yourself if you like. This patch is released into the public domain or MIT-licensed if you live somewhere that the public domain doesn't exist.

Else: Conrad Meyer <cse.cem@gmail.com>.

You've submitted other patches here, and none of them have authorship data. This means that anyone applying it must either manually add it in or take ownership of the diff; the former option is an annoyance for all developers looking at merging your code, and the latter option is illegal if you do not explicitly state, on each patch submission, that the patch has been released from your ownership.

I appreciate your submission, and I would be grateful it if you could change your local configuration to add in the authorship info prior to updating this patch with it.

abyomi0 edited edge metadata.Apr 7 2015, 3:29 PM
abyomi0 added a project: enlightenment-git.
abyomi0 removed a subscriber: enlightenment-git.
abyomi0 added a subscriber: abyomi0.Apr 7 2015, 3:32 PM

You had enlightenment-git as a subscriber...which notifies everyone who happens to be a member of the project. I've removed it as a subscriber and instead put it as a project.

c abandoned this revision.Apr 7 2015, 3:51 PM
In D2301#10, @zmike wrote:

I appreciate your submission, and I would be grateful it if you could change your local configuration to add in the authorship info prior to updating this patch with it.

No.

zmike changed the visibility from "All Users" to "Public (No Login Required)".Apr 7 2015, 4:12 PM
tasn added a subscriber: tasn.EditedApr 9 2015, 2:43 AM

I accepted this and pushed it in, just to end this stupid discussion.

However, @c, while we appreciate and welcome contributions, your patch doesn't follow our commit guidelines nor does it include the correct authorship information required for submissions.

If you'd like to make announcements like: "This patch is released into the public domain or MIT-licensed if you live somewhere that the public domain doesn't exist.", please do so upon submission so we can avoid the time wasted complaining about the missing authorship.

However, while I fixed it for you this time, patches that don't follow the commit guidelines will be rejected in the future.

Edit: just to clarify, I think @zmike is 100% right here.