Page MenuHomePhabricator

ecore_audio/pulse: Include libgen.h on FreeBSD to define basename(3)
ClosedPublic

Authored by c on Apr 8 2015, 3:52 PM.

Details

Reviewers
cedric
Summary

Fixes warning:

lib/ecore_audio/ecore_audio_obj_out_pulse.c:275:60: warning: implicit declaration of function 'basename' is invalid in C99
  [-Wimplicit-function-declaration]
   class_vars.context = pa_context_new(class_vars.api, basename(argv[0]));
                                                       ^
lib/ecore_audio/ecore_audio_obj_out_pulse.c:275:60: warning: incompatible integer to pointer conversion passing 'int' to parameter of
  type 'const char *' [-Wint-conversion]
   class_vars.context = pa_context_new(class_vars.api, basename(argv[0]));
                                                       ^~~~~~~~~~~~~~~~~
/usr/local/include/pulse/context.h:174:67: note: passing argument to parameter 'name' here
pa_context *pa_context_new(pa_mainloop_api *mainloop, const char *name);
                                                              ^
Test Plan

It now compiles without warning.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
c updated this revision to Diff 5296.Apr 8 2015, 3:52 PM
c retitled this revision from to ecore_audio/pulse: Include libgen.h on FreeBSD to define basename(3).
c updated this object.
c edited the test plan for this revision. (Show Details)
c added a project: efl.
c changed the visibility from "All Users" to "Public (No Login Required)".
cedric accepted this revision.Apr 10 2015, 2:16 AM
cedric added a reviewer: cedric.
This revision is now accepted and ready to land.Apr 10 2015, 2:16 AM
cedric closed this revision.Apr 10 2015, 2:16 AM