Page MenuHomePhabricator
Differential D2315

elm_spinner.c: Use correct fabs() for floating point spin_speed
ClosedPublic
Actions

Authored by c on Apr 8 2015, 4:30 PM.

Details

Reviewers
raster
Summary
elm_spinner.c:323:36: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
   if ((sd->spin_speed != 0.0) && (abs(sd->spin_speed) < sd->round))
                                   ^
elm_spinner.c:323:36: note: use function 'fabs' instead
   if ((sd->spin_speed != 0.0) && (abs(sd->spin_speed) < sd->round))
                                   ^~~
                                   fabs
Test Plan

After:

CC       libelementary_la-elm_spinner.lo
CCLD     libelementary.la

(No warning)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
c updated this revision to Diff 5298.Apr 8 2015, 4:30 PM
c retitled this revision from to elm_spinner.c: Use correct fabs() for floating point spin_speed.
c updated this object.
c edited the test plan for this revision. (Show Details)
c added a project: Restricted Project.
c changed the visibility from "All Users" to "Public (No Login Required)".
raster accepted this revision.Apr 27 2015, 1:12 AM
raster added a reviewer: raster.
raster added a subscriber: raster.

it seems tom already did this as part of 15764b5162c99a7561a236d38338012ab869379b

This revision is now accepted and ready to land.Apr 27 2015, 1:12 AM
raster closed this revision.Apr 27 2015, 1:12 AM

Revision Contents
Changeset List

PathPackages
Msrc/lib/elm_spinner.c (2 lines)

Diff 5298

View Options

src/lib/elm_spinner.c

Loading...