Page MenuHomePhabricator

tempget: Add more temperature sources for FreeBSD
ClosedPublic

Authored by c on Apr 12 2015, 9:28 AM.

Details

Summary

Not all motherboards have 'hw.acpi.thermal.tz0.temperature' sensor.
Fallback to 'dev.cpu.0.temperature' (provided by coretemp(4) or
amdtemp(4)), or 'dev.aibs.0.temp.0' (aibs(4)) (per suggestion of Dmitry
Luhtionov).

Test Plan

Ran src/modules/temperature/tempget manually with some debugging printfs and various sensors commented out. I can only test tz0 and dev.cpu (coretemp(4)) on my system.

Diff Detail

Repository
rE core/enlightenment
Lint
Lint Skipped
Unit
Unit Tests Skipped
c updated this revision to Diff 5334.Apr 12 2015, 9:28 AM
c retitled this revision from to tempget: Add more temperature sources for FreeBSD.
c updated this object.
c edited the test plan for this revision. (Show Details)
c added a project: enlightenment-git.
c changed the visibility from "All Users" to "Public (No Login Required)".
q66 accepted this revision.Apr 13 2015, 3:00 AM
q66 edited edge metadata.

this looks fine.

This revision is now accepted and ready to land.Apr 13 2015, 3:00 AM
q66 closed this revision.Apr 13 2015, 3:05 AM
q66 updated this revision to Diff 5338.

Closed by commit rE4389030678cd (authored by @q66).

q66 added a comment.Apr 13 2015, 3:06 AM

dude, please set your git config right... because of the lack of your correct git config it put me as the author of the commit. I forgot to check and now it's pushed. Fix it for your next revision

c added a comment.Apr 13 2015, 3:25 AM
In D2335#12, @q66 wrote:

dude, please set your git config right... because of the lack of your correct git config it put me as the author of the commit. I forgot to check and now it's pushed. Fix it for your next revision

This was the patch file I uploaded: http://dpaste.com/0W9W7PK

Phabricator has stripped the git information from it: https://phab.enlightenment.org/file/data/tsbiddmoj6ft5prd2iaw/PHID-FILE-mbcajdqdclpqjbf3xcka/D2335.diff

Not sure how I can "fix" that on my end.

q66 added a comment.Apr 13 2015, 3:27 AM

so you're not using arc to upload your patches? the procedure that leaves authorship information in is described here: https://phab.enlightenment.org/w/arcanist/