Page MenuHomePhabricator
Differential D3431

Add a new Ecore_Drm API
ClosedPublic
Actions

Authored by JHyun on Dec 10 2015, 8:52 PM.

Details

Reviewers
ManMower
raster
devilhorns
Commits
rEFLeb9b894167ea: Add a new Ecore_Drm API for setting left-handed mouse
Summary

Add a new Ecore_Drm API named ecore_drm_device_left_handed_set().

Libinput support various input options. Left handed mode is one of options.
Right-handed people and left-handed people use a mouse
using different button mapping.
So if a left handed option is enabled, libinput change right mouse button and
left mouse button.
So support this option, I added this api using libinput's left handed option.
Test Plan

After set left handed mode, left mouse button generate button numbered 3,

and right mouse button generate button numbered 1.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 892
Build 957: arc lint + arc unit
JHyun updated this revision to Diff 7791.Dec 10 2015, 8:52 PM
JHyun retitled this revision from to Add a new Ecore_Drm API.
JHyun updated this object.
JHyun edited the test plan for this revision. (Show Details)
JHyun added reviewers: devilhorns, raster.
JHyun added subscribers: input.hacker, duna.oh.
devilhorns requested changes to this revision.Dec 11 2015, 5:19 AM
devilhorns edited edge metadata.
devilhorns added inline comments.
src/lib/ecore_drm/ecore_drm_device.c
579

Why did you do "if (0 !=" here ??

Why not just "if (libinput_device_has_capability..." ??

586

I would prefer to have the function on the left and the result check on the right.

if (libinput_device_config_left_handed_set() != LIBINPUT_CONFIG_STATUS_SUCCESS)

This revision now requires changes to proceed.Dec 11 2015, 5:19 AM
JHyun edited edge metadata.Dec 13 2015, 7:02 PM
JHyun removed a subscriber: duna.oh.
JHyun added a subscriber: duna.oh.Dec 13 2015, 7:04 PM
JHyun edited subscribers, added: ohduna; removed: duna.oh.
JHyun updated this revision to Diff 7817.Dec 14 2015, 3:10 AM
JHyun edited edge metadata.

Fix some codes to adjust EFL coding style

JHyun updated this revision to Diff 7836.Dec 15 2015, 8:23 PM
JHyun edited edge metadata.

Change a API name more readable.

JHyun updated this revision to Diff 7882.Dec 17 2015, 10:02 PM

Remove unnecessary conditions.

JHyun updated this revision to Diff 7883.Dec 17 2015, 11:03 PM

Modify a argument left_handed type int to Eina_Bool.

JHyun updated this revision to Diff 7885.Dec 17 2015, 11:14 PM

Do not return False if set a left mouse with same value.

JHyun updated this revision to Diff 7905.EditedDec 20 2015, 3:06 PM

Remove a unused variable

ManMower requested changes to this revision.Dec 21 2015, 8:14 AM
ManMower edited edge metadata.

Just the one complaint, otherwise this looks good to me.

src/lib/ecore_drm/ecore_drm_device.c
569

Probably want to do something like left_handed = !!left_handed here to make sure the value is 0 or 1...

This revision now requires changes to proceed.Dec 21 2015, 8:14 AM
JHyun updated this revision to Diff 7923.Dec 21 2015, 6:23 PM
JHyun edited edge metadata.

Type change before add a value in variable Eina_Bool.

JHyun updated this revision to Diff 7924.Dec 21 2015, 6:28 PM
JHyun edited edge metadata.

Change a file authority type.

JHyun added a comment.Dec 27 2015, 11:00 PM

What I will do something for submit this commit?
If some modification point is exist, please notify to me. I will fix that.
Anyone who notify to me is exist?

devilhorns requested changes to this revision.Dec 28 2015, 6:08 AM
devilhorns edited edge metadata.
devilhorns added inline comments.
src/lib/ecore_drm/Ecore_Drm.h
380

missing @since 1.17 here

src/lib/ecore_drm/ecore_drm_device.c
576

This function does not exist at all, which breaks complie.

There is no ecore_drm_seat_evdev_list_get function in ecore_drm

This revision now requires changes to proceed.Dec 28 2015, 6:08 AM
JHyun updated this revision to Diff 7985.Dec 28 2015, 2:34 PM
JHyun edited edge metadata.

Remove a nonexistent function and add a function description

devilhorns accepted this revision.Dec 29 2015, 6:04 AM
devilhorns edited edge metadata.
Closed by commit rEFLeb9b894167ea: Add a new Ecore_Drm API for setting left-handed mouse (authored by JHyun, committed by devilhorns). · Explain WhyDec 29 2015, 6:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7923

View Options

src/lib/ecore_drm/Ecore_Drm.h

Loading...
View Options

src/lib/ecore_drm/ecore_drm_device.c

Loading...
View Options

src/lib/ecore_drm/ecore_drm_evdev.c

Loading...