- e_mouse_left_handed_set()
- Change mouse button mapping for left handed mode
- Change a mouse_hand config and save Currently e_mouse had e_mouse_update() API for support left_handed mode. But that API only for Xorg not support wayland and only for update mapping not change mapping. So I added new API for change mouse mapping for left handed mode and support wayland backend system.
Details
After set left handed mode using e_mouse_left_handed_set(),
mouse button mapping is changed for left handed people.
Diff Detail
- Repository
- rE core/enlightenment
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Needs changes for DRM compiling.
Also, unless there's an accompanying patch which adds config values and a UI for setting the option, I'm against merging this at all until such a patch is submitted.
src/bin/e_mouse.c | ||
---|---|---|
3 | Having Wayland does not in any way indicate DRM presence. Use HAVE_WL_DRM instead. | |
67 | Same as above. |
Unless I'm missing something, adding DRM functions in EFL has nothing to do with adding config values and GUI options in Enlightenment?
my bad. I misread your comment. I thought you were looking for the drm API that's being used here.
I change codes for DRM compiling.
But I don't understand another that you mentioned about config.
Config value 'mouse_hand ' have been existed. It is not new option.
Currently this option is defined in e.src. (Value 1: Right handed)
So I thought there is nothing to do for config.
But if my opinion is wrong, please tell me more specific for config.
Ahhhh okay, I misunderstood the purpose of this patch.
I think the better way of handling this would be to move the new code into e_mouse_update() and leave the config setting for outside of the e_mouse API. This means e_mouse_update() would look something like
if (e_comp->comp_type == E_PIXMAP_X) {all x11 code here} #ifdef HAVE_WL_DRM else if (strstr(ecore_evas_engine_name_get(e_comp->ee, "drm")) {your drm code here} #endif
I've broken out the existing X11 code, so now you just need to add yours below it with something like
#ifdef HAVE_WL_DRM if (strstr(ecore_evas_engine_name_get(e_comp->ee, "drm")) {your code} #endif
This looks pretty good in principle. Going to wait on DRM stuff to land first though.
src/bin/e_mouse.c | ||
---|---|---|
56 | This conditional seems impossible and is misleading for anyone reading the code; it should be removed. |