Adding option to disable cd to current tab dir.
Details
Details
- Reviewers
billiob - Group Reviewers
Terminology - Commits
- rTRM33d20a1f988a: Option to disable cd to current tab dir.
- Start unpatched version of Terminology.
- Change some Behaviour options.
- Close unpatched version of Terminology.
- Start patched version of Terminology.
- cd /usr/bin
- Open new tab and verify that previous behaviour persists, new tab working directory is /usr/bin
- Go to Settings Behaviour and uncheck "Start in the same directory..." checkbox.
- Optn new tab and verify that new tab working directory is ~ (or any other directory from which the Terminology was launched).
- Restart Terminology.
- Go to Settings Behaviour and verify that options persisted.
Diff Detail
Diff Detail
- Repository
- rTRM apps/terminology
- Branch
- start-in-workdir
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 934 Build 999: arc lint + arc unit
Comment Actions
I have one remark to do on that patch.
Could you change it from "Disable…" to "Enable…"? You should changed the default configuration to have it enabled by default, have a configuration upgrade in config_load().
Comment Actions
Man you're fast, you reviewed it before I even added reviewers!
But that means that I will have to increase the config version to 7 (to preserve existing behaviour as default), right? I did it at first but then changed to inverted not to touch config version for such minor thing.
Comment Actions
You can increase it, it's here for that. I did something like that in 144e0b5068aa25b7fce822a94101586f374aa236
Comment Actions
Hm ok, will change that, that indeed looks nicer than inverted flags. I'll need couple of hours to figure out arc+phab.
Comment Actions
Also, would appreciate advice on how to name the variable. changedir_to_current is the best I can think of...
Comment Actions
Thats a nice configuration option!
I'm wondering if we should also put it inside _split_split() and/or _win_split().
@billiob, what do you say?
Comment Actions
@godfath3r I agree.
In that case, the option configuration should be "Open new terminals in current working directory".
Comment Actions
Wait, you got me confused, do you mean current option should be renamed and similar behaviour added to split methods, or one more option should be added for that?
Comment Actions
Keep the code, just add the check for the option in the split code and change the line in options_behavior.c.
Comment Actions
- Changedir option changed to non-inverted.
- Option to change working directory added to split methods.