Page MenuHomePhabricator
Differential D3496

Passing KP_ keys to pty
ClosedPublic
Actions

Authored by TheIndifferent on Dec 25 2015, 12:51 AM.

Details

Reviewers
godfath3r
billiob
Group Reviewers
Terminology
Commits
rTRM2f3d2a944705: Passing KP_ keys to pty
Summary

KP_Home and KP_End were ignored, skipped because _handle_key_to_pty only checked for Kk keys.
It does not look like that was a typo, so handling for both Kk and KP now in place.

Test Plan
  1. start terminology
  2. type 'echo "the quick brown fox jumps over the lazy dog"'
  3. press keypad Home key
  4. on unpatched terminology nothing happens
  5. on patched terminology the behaviour is identical to normal Home

Diff Detail

Repository
rTRM apps/terminology
Branch
handle-kp-keys
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 935
Build 1000: arc lint + arc unit
TheIndifferent updated this revision to Diff 7974.Dec 25 2015, 12:51 AM
TheIndifferent retitled this revision from to Passing KP_ keys to pty.
TheIndifferent updated this object.
TheIndifferent edited the test plan for this revision. (Show Details)
TheIndifferent added reviewers: billiob, godfath3r.
TheIndifferent added subscribers: billiob, godfath3r.
godfath3r accepted this revision.Dec 25 2015, 3:41 AM
godfath3r edited edge metadata.

I've tried it and also looks valid to me.

This revision is now accepted and ready to land.Dec 25 2015, 3:41 AM
TheIndifferent added a comment.Dec 25 2015, 4:56 AM

I cannot find what to do next, do I have to do something to push it into git or one of the reviewers?

godfath3r added a comment.Dec 25 2015, 11:26 AM

I dont have commit permissions. Billiob should undertake this.

billiob accepted this revision.Dec 26 2015, 2:55 AM
billiob edited edge metadata.

I have no num pads on my keyboards. Thanks for the patch.

billiob closed this revision.Dec 26 2015, 2:56 AM
billiob edited edge metadata.
billiob added a project: Terminology.
TheIndifferent added a comment.Dec 26 2015, 3:04 AM
In D3496#55572, @billiob wrote:

I have no num pads on my keyboards. Thanks for the patch.

Well thanx for the awesomest terminal app ever! And except for the formatting style, code is really nice and clean, pleasure to work.

billiob added a comment.Dec 26 2015, 3:15 AM

I'm not found of the style either. Keep up the good work!

Revision Contents
Changeset List

PathPackages
Msrc/bin/keyin.c (2 lines)

Diff 7974

View Options

src/bin/keyin.c

Loading...