Page MenuHomePhabricator

Set cached xkb context/keymap
ClosedPublic

Authored by JHyun on Dec 28 2015, 3:11 AM.

Details

Summary

Set xkb context and keymap to Ecore_Drm.

In enlightenment (used in wayland with drm backend), keymap is used only one.
So for avoid unnecessary open keymap files, set cached context and keymap.
But for this, enlightenment must compile keymap before init ecore_drm.
So I changed booting sequence also.
Test Plan

Distinguish time between before and after during add a keyboard device.

Diff Detail

Repository
rE core/enlightenment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
JHyun updated this revision to Diff 7983.Dec 28 2015, 3:11 AM
JHyun retitled this revision from to Set cached xkb context/keymap.
JHyun updated this object.
JHyun edited the test plan for this revision. (Show Details)
JHyun added reviewers: raster, devilhorns.
JHyun added subscribers: ohduna, input.hacker, cedric.
zmike requested changes to this revision.Dec 28 2015, 8:39 AM
zmike edited edge metadata.

Moving the ordering of e_comp_wl_init() in this way breaks gl detection.

Is there a reason why this can't be done in the wl_drm module?

This revision now requires changes to proceed.Dec 28 2015, 8:39 AM

I wanted to set keymap before drm init.
Following my patch D3503, I want to remove unnecessary work about compile keymap.
In enlightenment maintain keymap globally. (not each of keyboard devices)
So I think that share only one keymap for enlightenment and efl side(Ecore_Drm).
But for this, compile keymap must be done earlier than Ecore_Drm init.

So I just think that change a init module sequence is not influence others.
But it is occurred miswork, I will think another way for earlier keymap compiling.

For this job, Have you any idea more simple way to cached keymap.
If you give me some idea, I will very appreciate to you.

JHyun updated this revision to Diff 7990.Dec 28 2015, 11:52 PM
JHyun edited edge metadata.

Fix a mis used variable

JHyun updated this revision to Diff 7992.Dec 29 2015, 3:58 AM
JHyun edited edge metadata.

Compile keymap before Ecore_Drm init

JHyun added a comment.Dec 29 2015, 3:59 AM

If change booting sequence is dangerous, how about this?

JHyun updated this revision to Diff 8004.Dec 29 2015, 10:31 PM

Add a use_cache option for keymap cache

zmike requested changes to this revision.Jan 4 2016, 9:56 AM
zmike edited edge metadata.

Please test compile before uploading new revisions.

This revision now requires changes to proceed.Jan 4 2016, 9:56 AM
JHyun updated this revision to Diff 8045.Jan 4 2016, 5:38 PM
JHyun edited edge metadata.

Modify a complict definition.

JHyun added a comment.Jan 4 2016, 5:55 PM

Oh, sorry for this conflict. I recognized that my build option is disabled wl-drm. So I cannot find this conflict. Check a new patch set plz.

This revision was automatically updated to reflect the committed changes.