Page MenuHomePhabricator

[edje][example] change wrong comment, and remove warnning message by adding ellipsis
ClosedPublic

Authored by kimcinoo on Dec 29 2015, 11:22 PM.

Details

Summary

Enhance edje color class example

Test Plan

build using the comment message

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kimcinoo updated this revision to Diff 8005.Dec 29 2015, 11:22 PM
kimcinoo retitled this revision from to [edje][example] change wrong comment, and remove warnning message by adding ellipsis.
kimcinoo updated this object.
kimcinoo edited the test plan for this revision. (Show Details)
kimcinoo added reviewers: raster, cedric, jpeg.
jpeg accepted this revision.Dec 30 2015, 12:12 AM
jpeg edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2015, 12:12 AM
seoz added a comment.Dec 30 2015, 7:06 AM

why didn't you just push, kimcinoo?

@seoz, good point. There is not a ssh key in my office, and I worried about forgetting to update this when I got back home :]

jpeg added a comment.Dec 30 2015, 6:59 PM
In D3508#55891, @seoz wrote:

why didn't you just push, kimcinoo?

Yeah, I forgot @kimcinoo had a dev access. Next time push directly. Please set up your ssh key at work and get the firewall approval as required.

Closed by commit rEFLa6da0315a8e6: edje example: change wrong comment, and remove warning message by adding… (authored by kimcinoo, committed by Jean-Philippe Andre <jp.andre@samsung.com>). · Explain WhyDec 30 2015, 7:36 PM
This revision was automatically updated to reflect the committed changes.
seoz added a comment.Dec 30 2015, 10:40 PM

haha you made JP's day!