Page MenuHomePhabricator

Set terminology window always to alpha true. Defaults opacity 100%.

Authored by godfath3r on Dec 30 2015, 4:41 AM.


Maniphest Tasks
Restricted Maniphest Task

This will fix T1106.

Test Plan

Putting this patch for review as I'm not sure for the impact. (side effects...)

Diff Detail

rTRM apps/terminology
No Linters Available
No Unit Test Coverage
Build Status
Buildable 966
Build 1031: arc lint + arc unit
godfath3r updated this revision to Diff 8009.Dec 30 2015, 4:41 AM
godfath3r retitled this revision from to Set terminology window always to alpha true. Defaults opacity 100%..
godfath3r updated this object.
godfath3r edited the test plan for this revision. (Show Details)
godfath3r added reviewers: raster, billiob, zmike.
raster requested changes to this revision.Dec 30 2015, 5:04 AM
raster edited edge metadata.

no. no no no. making it ALWAYS have alpha (even if opacity is 100%) has major performance side-ffects for the compositor. so - no.

This revision now requires changes to proceed.Dec 30 2015, 5:04 AM

Yeah, I had that feeling... I wanted to be sure :-P

Another (dirty) solution to get rid of window re-position on enabling the translucency, is to store "last known" x and y and position the elm_win there.
@raster, will that suffice?

Imho, window repositioning on alpha toggle looks ugly for the user.

if this is done, then you fundamentally change the window hints - you have to do this in ecore+evas ath the x11 level and provide user specified position hints. this will not work in all cases with all wm's - it may turn out poorly. tiling wm's will ignore such hints for example. so since it's only a partial solution... really is it worth it?

jpeg updated this object.Dec 30 2015, 8:55 PM
jpeg edited edge metadata.
jpeg added a task: Restricted Maniphest Task.
seoz added a subscriber: seoz.Dec 30 2015, 10:44 PM

I think it's worth trying as there will be high chance the previous position will be empty during window recreation. So it's likely be positioned in the same place.

This is not a perfect solution but as a user point of view, this is a best effort.

godfath3r abandoned this revision.Dec 31 2015, 3:12 AM

Yes, I'm not fond of this approach as it's not the cleaner one, but I can't hink of anything else... given that elm_win_alpha_set() doesn't provide this, it should be handled on application level.