Page MenuHomePhabricator

ecore_wayland: send mouse_move when sets touch_focus window in cb_touch_down
ClosedPublic

Authored by ohduna on Jan 11 2016, 12:47 AM.

Details

Summary

When user touches the screen, ecore_drm generates MOUSE_MOVE event before MOUSE_BUTTON_DOWN.
But when ecore_wayland gets touch_motion before touch_down, touch_focus window is NULL and sending MOUSE_MOVE event fails.
Also in terms of 'touch' input, touch_focus needs be set in cb_touch_down, not in cb_pointer_enter.
So this commit makes sure that ecore_wayland generates MOUSE_MOVE when touch_focus is set.

Test Plan

when the application is launched for first time, user clicks on any area of the screen.
We can see the posion of touch event wrong.

Diff Detail

Repository
rEFL core/efl
Branch
work
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1044
Build 1109: arc lint + arc unit
ohduna updated this revision to Diff 8110.Jan 11 2016, 12:47 AM
ohduna retitled this revision from to ecore_wayland: send mouse_move when sets touch_focus window in cb_touch_down.
ohduna updated this object.
ohduna edited the test plan for this revision. (Show Details)
ohduna added subscribers: input.hacker, cedric, JHyun.
ManMower accepted this revision.Jan 13 2016, 7:05 AM
ManMower edited edge metadata.

This looks better to me. When we get around to implementing wl_touch instead of emulating a mouse we won't get any surprise interactions between touch and mouse.

Thanks

This revision is now accepted and ready to land.Jan 13 2016, 7:05 AM
devilhorns accepted this revision.Jan 13 2016, 7:12 AM
devilhorns edited edge metadata.
devilhorns closed this revision.Jan 13 2016, 7:13 AM