Page MenuHomePhabricator

ecore-drm: return FALSE in all case, not only when rotation property is successfully set.
ClosedPublic

Authored by ohduna on Feb 14 2016, 5:32 PM.

Details

Summary

ecore_drm_output_rotation_set should be returning EINA_FALSE when the output doesn't have a plane of requested type.

Test Plan
  1. call ecore_drm_output_rotation_set() with ECORE_DRM_PLANE_TYPE_CURSOR
  2. If output doesn't have a plane of ECORE_DRM_PLANE_TYPE_CURSOR, the for statement does nothing. But return value is TRUE;

Diff Detail

Repository
rEFL core/efl
Branch
work
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1321
Build 1386: arc lint + arc unit
ohduna updated this revision to Diff 8433.Feb 14 2016, 5:32 PM
ohduna retitled this revision from to ecore-drm: return FALSE in all case, not only when rotation property is successfully set..
ohduna updated this object.
ohduna edited the test plan for this revision. (Show Details)
ohduna added subscribers: ManMower, JHyun, input.hacker.
devilhorns accepted this revision.Feb 15 2016, 5:45 AM
devilhorns edited edge metadata.
This revision is now accepted and ready to land.Feb 15 2016, 5:45 AM
devilhorns closed this revision.Feb 15 2016, 5:47 AM