Page MenuHomePhabricator

edje_external: check icon param after other param is set in entry
ClosedPublic

Authored by taxi2se on Feb 16 2016, 12:06 AM.

Details

Summary
  • icon param add an elm_icon and content set to icon part.
  • entry's style is changing as other params are set and icon part may not exist in certain condition(default has no icon part)
  • checking icon param later than other params will set icon part after the style is changed.

Diff Detail

Repository
rELM core/elementary
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1342
Build 1407: arc lint + arc unit
taxi2se updated this revision to Diff 8456.Feb 16 2016, 12:06 AM
taxi2se retitled this revision from to edje_external: check icon param after other param is set in entry.
taxi2se updated this object.
taxi2se edited the test plan for this revision. (Show Details)
taxi2se added a subscriber: conr2d.
jpeg edited edge metadata.Feb 16 2016, 12:41 AM

any test case for this?

This external param "icon" does not work fine even after this patch.
For now, external elm_entry has following malfunctions.

  1. "default" style does not have SWALLOW part for "icon"
    • So, currently, warning that content_set is failed is printed . This will be fixed by this patch.
  2. Icon set by this external param does not have a min size.
    • Even after this patch, icon can be swallowed but cannot be position well because "icon" part is defined to expand by its size from the left line. It will look awkward because elm_icon set by this param does not have a min size.
tasn accepted this revision.Feb 18 2016, 8:10 AM
tasn edited edge metadata.

This is correct.

@jpeg, how would you test it? If there's a way, go ahead, otherwise, I think you can just let it in.

This revision is now accepted and ready to land.Feb 18 2016, 8:10 AM
cedric accepted this revision.Feb 18 2016, 1:31 PM
cedric closed this revision.
cedric edited edge metadata.